Scgpt update #87
Open
Scgpt update #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Luke Zappia <[email protected]>
rcannood
requested changes
Oct 19, 2025
Comment on lines
-54
to
-62
| # TODO: Try to find working installation of flash attention (flash-attn<1.0.5) | ||
| setup: | ||
| #- type: python | ||
| # pypi: | ||
| # - gdown | ||
| # - scgpt # Install from PyPI to get dependencies | ||
| #- type: docker | ||
| # # Force re-installing from GitHub to get bug fixes | ||
| # run: pip install --upgrade --no-deps --force-reinstall git+https://github.com/bowang-lab/scGPT.git |
There was a problem hiding this comment.
Suggested change
| # TODO: Try to find working installation of flash attention (flash-attn<1.0.5) | |
| setup: | |
| #- type: python | |
| # pypi: | |
| # - gdown | |
| # - scgpt # Install from PyPI to get dependencies | |
| #- type: docker | |
| # # Force re-installing from GitHub to get bug fixes | |
| # run: pip install --upgrade --no-deps --force-reinstall git+https://github.com/bowang-lab/scGPT.git | |
| setup: |
This shouldn't be removed
| type: integer | ||
| description: The maximum length of the gene sequence. | ||
| default: 4000 | ||
| default: 2300 |
There was a problem hiding this comment.
this was already merged, right?
There was a problem hiding this comment.
then I don't see why it still shows as a modification... :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
moving this to a new PR